search

skrapeit / skrape.it

A Kotlin-based testing/scraping/parsing library providing the ability to analyze and extract data from HTML (server & client-side rendered). It places particular emphasis on ease of use and a high level of readability by providing an intuitive DSL. It aims to be a testing lib, but can also be used to scrape websites in a convenient fashion.
https://docs.skrape.it
MIT License
813 stars 59 forks source link

[IMPROVEMENT] use kotlins stdlib assert to match elements #76

Closed christian-draeger closed 4 years ago

christian-draeger commented 4 years ago

Skrape{it} provides matchers that are internally using the strikt library. Strikt is a great library and we should continue using it as the assertion library of choise within our unit tests. However the kotlin standard library provides native Asserts that we should evaluate if we can use them in our production code to match elements behavior. They will throw an AssertionError if runtime assertions have been enabled on the JVM using the -ea JVM option - we need to check if this is applicable for skrape{it}s use cases. If not we could also provide a custom exception with meaningful message.

Thereby the number of transitive dependencies will be reduced and it will not lead to confusion because strikt needs jcenter repository.

christian-draeger commented 4 years ago

we make the assertions on our own now - no 3rd party library involved anymore and therefore also no dependency clashes or unresolved dependencies anymore will be part of the 1.0.0 final release 🥳