skrashevich / double-take

Unified UI and API for processing and training images for facial recognition.
https://hub.docker.com/r/skrashevich/double-take
MIT License
536 stars 26 forks source link

[BUG] Pic with bounding box from Frigate snapshot is being used #354

Closed TyzzyT closed 7 months ago

TyzzyT commented 9 months ago

Describe the bug When using the snapshots from Frigate, the latest snapshot after the event has finished has a bounding box rendered in the snapshot. This means that the image passed to CompreFace is with a bounding box from Frigate. With Frigate 0.13 you also have a bounding box around the face when using the Frigate+ model, this is causing issues with the detection of faces. I'd like Frigate to show the bounding boxes on the snapshot image on the Events page, but don't want Double Take to process a snapshot with a bounding box around the face. Within Frigate I use clean_copy: True but I'm not sure if it's possible to only download the snapshot without a bounding box, because the Frigate docs say Accepts the following query string parameters, but they are only applied when an event is in progress. After the event is completed, the saved snapshot is returned from disk without modification I'm not sure if this is something Double Take can fix, but I need to start somewhere. If you can't do anything about this problem, I'm more than happy to open an issue in the Frigate repo.

Version of Double Take v1.13.11.8

Expected behavior I would expect Double Take to only pass images without a bounding box to CompreFace

Configuration Frigate config

    snapshots:
      enabled: true
      clean_copy: true
      bounding_box: true

Double Take config

frigate:
  url: http://ccab4aaf-frigate-fa-beta:5000 # url of the Frigate server
  update_sub_labels: true # if double take should send matches back to frigate as a sub label
  stop_on_match: false # if set to false all image attempts will be processed before determining the best match
  labels:
    - person
  zones:
    - camera: frontgarden
      zone: frontgarden_zone # only proces images from voortuin zone
  events:
    frontgarden:
      attempts:
        latest: 10 # number of times double take will request a frigate latest.jpg for facial recognition
        snapshot: 10 # number of times double take will request a frigate snapshot.jpg for facial recognition
skrashevich commented 9 months ago

set

Frigate config

    snapshots:
      enabled: true
      clean_copy: true
      bounding_box: true

just set bounding_box to false

TyzzyT commented 9 months ago

I said in my initial post: I'd like Frigate to show the bounding boxes on the snapshot image on the Events page, but don't want Double Take to process a snapshot with a bounding box around the face. That why I think setting bounding_box to false is not an option. I guess there is no way to achieve this, so I'll open a feature-request in the Frigate repo for this.

skrashevich commented 9 months ago

Oh, I didn’t notice it. In this case, you need to use the 'latest' instead of a 'snapshot'

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

TyzzyT commented 7 months ago

Yes, but it would be nice to have both. The snapshot image is updated at a different interval, so it would be nice to have the snapshot too, but without a bounding box. I think this is something for the Frigate repo, so we can close this one.