search

skrashevich / hassio-addons

15 stars 17 forks source link

Add CompreFace add-on and bump to 1.2.0 #10

Open felipecrs opened 1 year ago

felipecrs commented 1 year ago

You suggested me to use CompreFace for facial recognition (https://github.com/skrashevich/double-take/discussions/109#discussioncomment-6961826), so I gave https://github.com/jakowenko/double-take-hassio-addons/tree/master/compreface a try. But then I noticed it is outdated so I'm sending this PR for you. :)

I only copied as is, then I bumped the CompreFace version.

https://github.com/exadel-inc/CompreFace/releases/tag/v1.2.0

It seems to be working fine, according to my tests.

And thanks for bringing double take back to life!

felipecrs commented 1 year ago

Ops, sorry @skrashevich, I actually did some changes just now.

felipecrs commented 1 year ago

I'm done with the changes now.

skrashevich commented 1 year ago

good work, but it's not a hassio-way :(

you need to install S6Overlay over original compreface container. you can refer to this dockerfile: it does the same thing over the aiserver container. Compreface startup script supports EXTERNAL_DB env variable -- use it. /run.sh script must read options from /data/options.json, then set appropriate variables (env, config, etc...) and execute original startup command (/usr/bin/supervisord).

unfortunately, official addon developer documentation really awful, but it's good start point

felipecrs commented 1 year ago

Ok, I knew all these caveats and I will work on it.

As mentioned, I just copied it as is from the original. It was not really my goal to refactor the whole add-on at the moment.