search

skratchdot / color-harmony

Create color scales by rotating hue
MIT License
85 stars 9 forks source link

Remove util dependency #1

Closed michaelrhodes closed 9 years ago

michaelrhodes commented 9 years ago

Hey, great module! :) I was wondering if you’d consider removing the util dependency? Reason being, it adds ~20kb to the bundle, and the only method being used, isArray, can be polyfilled in a couple of lines.

skratchdot commented 9 years ago

yes, i'll pull this in, will have to update the version number at some point, but this makes sense. i doubt anyone's really using this library, but i think a better solution is figuring out how to "fix" browserify to include util.isArray() efficiently. That's a pretty complicated task though. There's probably an "is-array" lib out there that is smaller (and supports older browsers). 20kb is definitely not necessary for 1 fn being used.

Anyways, thanks for the fix.