skratchdot / open-golang

Open a file, directory, or URI using the OS's default application for that object type. Optionally, you can specify an application to use.

MIT License

789 stars 64 forks source link

causing goplay installation failed. #22

Closed adamtang79 closed 5 years ago

adamtang79 commented 5 years ago

... > go get -v -u github.com/haya14busa/goplay/cmd/goplay github.com/haya14busa/goplay (download) github.com/skratchdot/open-golang (download) github.com/skratchdot/open-golang/open

github.com/skratchdot/open-golang/open

..\skratchdot\open-golang\open\exec_windows.go:10:2: imported and not used: "syscall"

mkgti commented 5 years ago

exec_windows.go:10：2 Notes “syscall” //“syscall”

goplay SUCCEEDED

jakubknejzlik commented 5 years ago

Is there any reason to comment out those lines instead of removing them?

adamtang79 commented 5 years ago

I will remove those lines if this is my project. But since the previous open window issue was to comment those line, I think it might make sense to follow the previous pattern :D

mkgti commented 5 years ago

Commits on Mar 31, 2019 commenting out another line from #17 that was missed in 7972e18

skratchdot skratchdot committed 2 days ago

func openWith(input string, appName string) *exec.Cmd { cmd := exec.Command("cmd", "/C", "start", "", appName, cleaninput(input)) "reduce" cmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true} "add" //cmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true} return cmd }

in "syscall" imported and not used

skratchdot commented 5 years ago

Sorry about this. I should've just reverted #17 instead.