search

skratchdot / react-bootstrap-multiselect

A multiselect component for react (with bootstrap). This is a react port of bootstrap-multiselect.
http://projects.skratchdot.com/react-bootstrap-multiselect/
Other
119 stars 62 forks source link

Play nicely when bootstrap dropdown is already loaded. #61

Closed rosselliott closed 7 years ago

rosselliott commented 7 years ago

If bootstrap.dropdown is already loaded then the multi select dropdown will never open as two handlers will be attached to the element. As the handlers will both toggle the 'open' class the net effect is that the dropdown will remain closed.

JrmKrb commented 7 years ago

Would be awesome if it could be merged!

skratchdot commented 7 years ago

@rosselliott / @JrmKrb - sorry for the delay on this. I missed it. Thank you for this PR!

rvaidya commented 7 years ago

Can we get a version bump for this on npm?

JrmKrb commented 7 years ago

Thank you @skratchdot !

skratchdot commented 7 years ago

@rvaidya - the build isn't working for me right now. I'm going to try to make a few updates before publishing. Might finally get around to adding some tests as well. I probably won't get to this until after work today (so if I forget, feel free to drop another message in here)

sman591 commented 7 years ago

require('bootstrap') is throwing an error for me rather than silently falling back to require('./bootstrap-multiselect.js'); - I'm building with Webpack & babel.