search

skratchdot / react-bootstrap-multiselect

A multiselect component for react (with bootstrap). This is a react port of bootstrap-multiselect.
http://projects.skratchdot.com/react-bootstrap-multiselect/
Other
119 stars 62 forks source link

Migrate from createClass() to es6 classes #71

Closed sman591 closed 7 years ago

sman591 commented 7 years ago

Fixes #68

Also had to add babel to the gulp build in order to properly build the demo app.

The demo app & readme also could use some updating, but I figure that can happen outside of this PR.

I've tested this with the demo app & my own app (though had to fix a bootstrap import on a custom branch).

skratchdot commented 7 years ago

Thanks for this! I've been wanting to update the demo, or use react-storybook instead. I'd also like to make sure builds work with webpack (since that's what most people, including me, are using nowadays). I'll pull this in and push a new build.

skratchdot commented 7 years ago

I also don't like the "Note on data synchronization" that I merged in at one point. I'd like to update that for people b/c it doesn't look like any other typical React usage I've seen....

sman591 commented 7 years ago

Happy to!

skratchdot commented 7 years ago

@sman591 - I just published 2.4.0 with your changes. Thanks again!