skraus-dev / cherryrgb-rs

Cherry RGB Keyboard - Multi platform tool to set RGB LEDs for Cherry keyboards
MIT License
41 stars 3 forks source link

Query rusb for detach support #43

Closed felfert closed 1 year ago

felfert commented 1 year ago

Description

This PR provides a very minimal change for the condition of enabling the auto_detach_kernel feature. Instead of enabling it on all unix platforms, it actually queries the relevant flag of libusb. rusb provides a function for that specifically.

Type of change

Code Checklist

@skraus-dev PS: Now that CI/CD is working again and my solution to #22 (introducing the VHID driver) is here, I would LOVE to see a new release soon. (I already have an updated rpm spec file for fedora packaging and as soon as the next version is available, I can provide Fedora packages with preconfigured systemd service).

skraus-dev commented 1 year ago

Thx for the addition.

Yup, will draft a new release now.

UPDATE: Will start drafting the new release when the ubuntu apt mirror, used in the CI chain, is fixed. Currently its returning 503 for a few dependencies.

felfert commented 1 year ago

Yup, will draft a new release now.

UPDATE: Will start drafting the new release when the ubuntu apt mirror, used in the CI chain, is fixed. Currently its returning 503 for a few dependencies.

Hmm. crates.io the (doc) build failed: https://docs.rs/crate/cherryrgb/0.2.5/builds/817053

They use a nightly toolkit and maybe the build config there should be updated too (Adding --feadures uhid)