Improvements - Githubissues

skraus-dev / cherryrgb-rs

Cherry RGB Keyboard - Multi platform tool to set RGB LEDs for Cherry keyboards

MIT License

41 stars 3 forks source link

Improvements #7

Closed felfert closed 1 year ago

felfert commented 1 year ago

Hi Sebastian,

As promised in #5, here is a revised PR. This time, I separated it into 3 commits:

The first commit contains the refactoring to using strum and strum_macros.
The second commit contains the additional filter using a blacklist of product ids (currently only one).
The last one, adds the MX 10.0N related stuff (just an additional const and the README.md change).

Cheers -Fritz

felfert commented 1 year ago

BTW: It would be nice to have your table of supported devices in #3 in a separate markdown file. This makes it possible to submit PRs if someone actually tests a device successfully. Also: There is a "bug" in that table: Key remap is not yet implemented for G80 3000N TKL RGB

Cheers -Fritz

skraus-dev commented 1 year ago

hey Fritz!

Indeed I didn't got alerted for the PR, will enable notifications now, so thx for the mail. PR looks good and cleans up the enum portion quite a bit.

Will create the table in the repo and then link to it instead of the issue being the origin of that information.