search

skrollme / homebridge-eveatmo

Homebridge plugin which adds a Netatmo weatherstation as HomeKit device and tries to act like Elgato Eve Room/Weather
Apache License 2.0
69 stars 7 forks source link

add config.schema.json to get a UI configuration dialog #36

Closed lisanet closed 4 years ago

lisanet commented 4 years ago

This add a configuration dialog for the homebridge-config-ui-x plugin, so that users can easily configure the eveatmo plugin via the config web UI.

skrollme commented 4 years ago

Hello @lisanet , thank you for your contribution. I will try to check this out next weekend and merge the PR.

skrollme commented 4 years ago

Hello @lisanet , I'm currently testing your PR and everything works fine except one startup-error here:

https://github.com/lisanet/homebridge-eveatmo/blob/master/device/weatherstation-device.js#L60

[2020-1-4 15:14:28] ReferenceError: NULL is not defined
    at WeatherstationDeviceType.<anonymous> (/usr/lib/node_modules/homebridge-eveatmo/device/weatherstation-device.js:60:14)

If I change the NULL to null, everything works. Maybe a different node-version (I'm using 8.4). If you want I can change this and merge your PR.

skrollme commented 4 years ago

... one more thing: It would also be great if you can change the PR target branch to the develop-branch.

lisanet commented 4 years ago

ok, I've changed the PR to target your develop branch.