skrollme / homebridge-eveatmo

Homebridge plugin which adds a Netatmo weatherstation as HomeKit device and tries to act like Elgato Eve Room/Weather
Apache License 2.0
69 stars 7 forks source link

New Feature: Support for Netatmo's Air Quality Monitor #52

Closed foliveira closed 3 years ago

foliveira commented 4 years ago

This pull request adds support for Netatmo's Air Quality Monitor - also known as HomeCoach.

It's based on the Smart Home Station already supported by this module and can be toggled on/off with the module's config (default state is off).

NPM module netatmo already supports the call for the correct API calls with getHealthyHomeCoachData(), which then proceeds to populate a Eve Home like device supported by Homebridge. Supports Noise data, that can be checked with an alternative app like Eve Home.

skrollme commented 3 years ago

Sorry for the late response. Because I cannot test this I will merge this and prepare a new release for this. Are there any information which should be added to the documentation / readme @foliveira ?

foliveira commented 3 years ago

Hi @skrollme

I can add a mock api (for tests) and there’s also a bit of documentation on the new configuration keys that needs to be added.

skrollme commented 3 years ago

Would be great if you could add some information about the config-values to the readme. Concerning testing: I meant I do not have this device at home so I cannot make "real life" tests. I believe / hope you have tested it with your device and/or mock-data ;)

foliveira commented 3 years ago

I’ll add some screenshots of it supporting the device, update the README with the new configs and add mock api data to the PR

(I have it running for a few weeks now with a real device and everything works 👍 - will get screenshots as I mentioned)

foliveira commented 3 years ago

Hi @skrollme

Just pushed a new commit with the relevant updates to README.md and mock api calls

Also a screenshot of the current version working with Eve.app

IMG_0703

And with Home.app

IMG_171635BF6657-1

skrollme commented 3 years ago

Thank you for your work, @foliveira . I'm really appreciate it. It feels like rarity (at least in my projects) that there are people who really contribute instead of just writing "that does not work" or "I want that!"

I just merged your work and prepared everything for the npm release. 0.6.0 should be published soon

foliveira commented 3 years ago

Thanks @skrollme - I had already written a module to support this device, so it made perfect sense to rework that and integrate into this project.

Feel free to ping me if any questions/bugs come up with this (hopefully that doesn’t happen 😅)

skrollme commented 3 years ago

I just added a default value for the weatherstation config-value (see https://github.com/skrollme/homebridge-eveatmo/blob/master/index.js#L19) because otherwise the weatherstation accessories would disappear for all user which would just update without changing their config. Edit: ... for users without config-ui-x

foliveira commented 3 years ago

Good point. Since I use config-ui-x and don’t own a Weatherstation that one fell through; not having it for the AirQuality monitor should be fine as it is disabled by default, am I right in assuming that?

skrollme commented 3 years ago

That is correct 👌