search

skrollme / homebridge-eveatmo

Homebridge plugin which adds a Netatmo weatherstation as HomeKit device and tries to act like Elgato Eve Room/Weather
Apache License 2.0
69 stars 7 forks source link

Added flag to enable/disable AirQuality sensor for indoor module #76

Closed Tellicious closed 5 months ago

Tellicious commented 11 months ago

I added an additional config item to disable the AirQuality sensor that is automatically created (reporting CO2 level), so that you can decide to show only the CO2 sensor. In most Homekit implementations, CO2 level is only reported within the sensor and not as part of AirQuality. This way you can do both

skrollme commented 5 months ago

Thanks for your Pull Request, @Tellicious . As you may have already noticed, I do not look very often into this repository, so I'm apologizing for responding so late.

Concerning your changes: I think it would be better to set the default-value to true, because if anyone updates to this version their sensor would disappear, or am I wrong?

Tellicious commented 5 months ago

No worries, it was nothing urgent.

You’re right about the default value: shall I update the PR or do you want to do it?

skrollme commented 5 months ago

I just changed the target branch to develop and I will do this while testing. I create a new release for NPM afterwards. Thank you for your contribution, @Tellicious