search

skroutz / rafka

Kafka proxy with a simple API, speaking the Redis protocol
https://engineering.skroutz.gr/blog/kafka-rails-integration/
GNU General Public License v3.0
8 stars 0 forks source link

Conform to Kafka id naming rules #23

Closed agis closed 7 years ago

agis commented 7 years ago

Kafka only allows [a-zA-Z0-9\\._\\-] being used in group.id and client.id (see this and this). Doing otherwise causes weird errors when attempting to set the client.id for example (eg. Unknown broker error) .

We should make sure our internal IDs are constructed according to Kafka rules.

agis commented 7 years ago

We took a different approach by keeping our IDs as they were and only using portions of them to Kafka: https://github.com/skroutz/rafka/commit/2b998d38cc89d7695a3f1b8e0a33adb33ac248ed.