skroutz / rafka

Kafka proxy with a simple API, speaking the Redis protocol
https://engineering.skroutz.gr/blog/kafka-rails-integration/
GNU General Public License v3.0
8 stars 0 forks source link

consumer: Accept configuration from clients #53

Closed agis closed 6 years ago

agis commented 6 years ago

Closes #19

agis commented 6 years ago

Tests will be added soon.

dtheodor commented 6 years ago

updated: a client config can be passed as a JSON object to BLPOP topics:<topic>|<JSON-encoded consumer config> <timeoutMs>

it overwrites any values set by the server's consumer config. validation happens the moment the kafka consumer is instantiated, we don't need to do any additional validation on our side

dtheodor commented 6 years ago

Addressed comments