search

skroutz / rspecq

Distribute and run RSpec suites among parallel workers; for faster CI builds
https://rubygems.org/gems/rspecq
MIT License
161 stars 24 forks source link

CI: Add Ruby 3.1, 3.0, but only for latest RSpec #76

Closed olleolleolle closed 2 years ago

olleolleolle commented 2 years ago

This PR extends the build matrix with the two latest Ruby versions.

This also formats a YAML list, to make the GitHub editor not complain about formatting.

Arguable 2.7 could be in there, becoming the oldest build target.

agis commented 2 years ago

Thanks for re-working this to work with GitHub Actions! This looks good to me, apart from a comment left on the original PR (quoting here for convenience):

One thing I'd like to do, is to only test 3.0 and 3.1 with the latest rspec core (I think it's 0.11 as of now), not everything that's in the matrix.

The reason for this is just to avoid a big number of builds that add little value. Testing only with latest rspec-core should be fine. Let's keep 2.5 tested with all rspec-core versions though.

Arguable 2.7 could be in there, becoming the oldest build target.

Yes, let's add 2.7 as well, since it's in the "stable" set.

agis commented 2 years ago

Can you rebase on top of master? The 3.1 failure should be fixed by https://github.com/skroutz/rspecq/commit/10071ee93a368c896ad6b94eef952d73ebc9d860 that was pushed a few minutes ago.

olleolleolle commented 2 years ago

@agis There, rebased.

agis commented 2 years ago

Thank you!