accept duplicate column names in table report

skrub-data / skrub

Prepping tables for machine learning

https://skrub-data.org/

BSD 3-Clause "New" or "Revised" License

1.23k stars 98 forks source link

accept duplicate column names in table report #1125

Closed jeromedockes closed 1 month ago

jeromedockes commented 1 month ago

fixes #1117

also remove the first_row_dict function which is not used anywhere

jeromedockes commented 1 month ago

I don't know all the internals but the output looks good to me :)

thanks for checking! there's not much to it it's just making sure we retreive a column by giving its index rather than its name so we don't get any problems when it's a pandas dataframe with duplicate column names. not sure what's going on with codecov ci but I checked the added lines are covered by the tests by running them locally