Copy pandas index to output of OnEachColumn and OnSubFrame

skrub-data / skrub

Prepping tables for machine learning

https://skrub-data.org/

BSD 3-Clause "New" or "Revised" License

1.16k stars 97 forks source link

Copy pandas index to output of OnEachColumn and OnSubFrame #942

Closed jeromedockes closed 3 months ago

jeromedockes commented 3 months ago

ATM the outputs have the default 1,...,n index. This preserves the index of the input, as is done by scikit-learn when the input is a pandas dataframe and set_output(transform='pandas')

jeromedockes commented 3 months ago

the test failures are not related to the PR but numpy 2, they will be fixed by #946

jeromedockes commented 3 months ago

@glemaitre thanks for the review -- I think I've addressed your comments now

glemaitre commented 3 months ago

Thanks @jeromedockes