case class schema derivation: inherit namespace from sealed trait

sksamuel / avro4s

Avro schema generation and serialization / deserialization for Scala

Apache License 2.0

714 stars 236 forks source link

case class schema derivation: inherit namespace from sealed trait #833

Closed mberndt123 closed 2 months ago

mberndt123 commented 2 months ago

Back in Avro4s 4, case classes inherited the @Namespace attribute from their parent trait. This behaviour changed in Avro4s 5, leading to all sorts of incompatible schema changes in our project.

I think the old behaviour was actually more sensible, so this PR restores it.

sksamuel commented 2 months ago

This is a regression so I agree.