search

sksamuel / avro4s

Avro schema generation and serialization / deserialization for Scala
Apache License 2.0
719 stars 237 forks source link

support ByteBuffers that have hasArray=false #838

Closed pjfanning closed 4 months ago

pjfanning commented 4 months ago

see #837

I need to follow up and add some test coverage. This is just an outline of the changes.

pjfanning commented 4 months ago

@sksamuel The tests I added do provide regression testing for buffers with hasArray=false. Do you think it is enough? I don't have a great deal of time to spend on adding extra coverage, I'm afraid.

sksamuel commented 4 months ago

I think this looks good.