Closed wafna closed 6 months ago
This health check simply uses ds.hikariPoolMXBean.totalConnections
from a HikariDataSource.
Maybe you need to call .close() on the source when you're finished and want to shut down.
It does call close on the Hikari CP. You can see it in the debugger. Nevertheless, the CP does not close.
On Sat, Jun 10, 2023 at 5:15 PM Sam @.***> wrote:
This health check simply uses ds.hikariPoolMXBean.totalConnections from a HikariDataSource. Maybe you need to call .close() on the source when you're finished and want to shut down.
— Reply to this email directly, view it on GitHub https://github.com/sksamuel/cohort/issues/41#issuecomment-1585869787, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALGGT3EIG4IILQKGZWNFY3XKUE3TANCNFSM6AAAAAAY7WL2TY . You are receiving this because you authored the thread.Message ID: @.***>
Ok it's not the DB pool, it's the registry itself. I'm adding a fix to the pending 2.1.0 release.
This was fixed back in 2.1
The
HikariConnectionsHealthCheck
seems to permanently hold connections and prevent the data source from cleaning up.Below, is a demonstration.