search

sksamuel / hoplite

A boilerplate-free Kotlin config library for loading configuration files as data classes
Apache License 2.0
924 stars 74 forks source link

Java 8 Support #405

Closed ghost closed 8 months ago

ghost commented 8 months ago

Is there any particular reason to not support java 8?

sksamuel commented 8 months ago

Other than its 1000 years old, I suppose not if the project compiles with it :)

ghost commented 8 months ago

Other than its 1000 years old, I suppose not if the project compiles with it :)

I built it with that without any problems

sksamuel commented 8 months ago

If you want to make a PR I'll release 2.8.0 on JDK8

ghost commented 8 months ago

If you want to make a PR I'll release 2.8.0 on JDK8

That would be great! Is there anything else than changing the target version? Also noticed, that because of the quite old postgres version in test, it was failing for me because of a wrong timezone, update to latest fixed that

sksamuel commented 8 months ago

Ok cool. Yeah should just be a matter of changing the gradle build files, and then the GHA workflows.

ghost commented 8 months ago

Ok cool. Yeah should just be a matter of changing the gradle build files, and then the GHA workflows.

Done, https://github.com/sksamuel/hoplite/pull/406 Although, did not touch the workflows, explained why in the PR

ghost commented 8 months ago

That is it! Thank you :)