Fix decoding of data classes in maps, and denormalizing map keys consistently

sksamuel / hoplite

A boilerplate-free Kotlin config library for loading configuration files as data classes

Apache License 2.0

924 stars 74 forks source link

Fix decoding of data classes in maps, and denormalizing map keys consistently #444

Closed rocketraman closed 2 months ago

rocketraman commented 3 months ago

Resolves https://github.com/sksamuel/hoplite/issues/443.

This PR starts from the regression repro created by @osoykan (b256e2e13d1f11109142d3c533c028b44aa3bdad), modifies it to a minimal issue reproduction (4b706655cd50b7e2b68b79905810f57054ddd401), and then fixes the two related problems (da9706c433d70b3d7d578c45442d1b10eeff8b63 and 3922914cf21f7e58706c6edf558cd3de92ab2084).

rocketraman commented 2 months ago

@sksamuel Sorry, put the comment on the issue instead of the PR... would appreciate a review and merge of this asap, because current master is a bit broken.