First of all, thank you for creating an awesome JVM library and providing it as open source.
I'm using the scrimage library for webp encoding. It seems to be using cwebp for encoding, and I can apply several option flags, including noalpha. I think it would be nice to additionally support the (-mt) multithread option provided by cwebp.
The multithread feature is already provided in libwebp-1.3.2 cwebp, so if it is provided as an optional flag, I think it will work fine. I've added a new constructor for WebpWriter (keeping the old ones), and I don't think there should be any problems with backwards compatibility since the mt option defaults to false.
If you don't mind, I hope you will accept my MR.
sksamuel
commented
2 months ago
Hello.
First of all, thank you for creating an awesome JVM library and providing it as open source.
I'm using the scrimage library for webp encoding. It seems to be using
cwebpfor encoding, and I can apply several option flags, includingnoalpha. I think it would be nice to additionally support the (-mt) multithread option provided by cwebp.The multithread feature is already provided in libwebp-1.3.2 cwebp, so if it is provided as an optional flag, I think it will work fine. I've added a new constructor for WebpWriter (keeping the old ones), and I don't think there should be any problems with backwards compatibility since the mt option defaults to false. If you don't mind, I hope you will accept my MR.