sktime / pytorch-forecasting

Time series forecasting with PyTorch
https://pytorch-forecasting.readthedocs.io/
MIT License
3.87k stars 612 forks source link

&felipeangelimvieira, yarnabrina [MNT] CI step to test that notebooks run #1621

Closed fkiraly closed 3 weeks ago

fkiraly commented 3 weeks ago

This adds a CI step to run all the tutorial notebooks.

The test passes if all tutorial notebooks run without error, and can be used to test the fixes in https://github.com/jdb78/pytorch-forecasting/pull/1615

fkiraly commented 3 weeks ago

FYI @XinyuWuu, @yarnabrina, any ideas why the GHA cannot see the sh script?

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.19%. Comparing base (862c5da) to head (4f21f7b). Report is 8 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1621 +/- ## ======================================= Coverage 90.19% 90.19% ======================================= Files 30 30 Lines 4722 4722 ======================================= Hits 4259 4259 Misses 463 463 ``` | [Flag](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1621/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | Coverage Δ | | |---|---|---| | [cpu](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | `90.19% <ø> (ø)` | | | [pytest](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | `90.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fkiraly commented 3 weeks ago

credits:


[tool.setuptools]
py-modules = ["pytorch_forecasting"]

[build-system]
build-backend = "setuptools.build_meta"
requires = [
  "setuptools>61",
]

suggestio due to @felipeangelimvieira

fkiraly commented 3 weeks ago

oh, still permission denied

yarnabrina commented 3 weeks ago

I think you haven't changed file level permission, e.g. with chmod. Do you want me to push a test commit in this branch?

fkiraly commented 3 weeks ago

I think you haven't changed file level permission, e.g. with chmod. Do you want me to push a test commit in this branch?

would be appreciated! Probably a problem with my windows

yarnabrina commented 3 weeks ago

I think it's working now, please take a look. All I did is this:

cd build_tools
chmod +x run_examples.sh

CI failed because of code issue, the permission one is resolved.

fkiraly commented 3 weeks ago

Nice! The test now runs as intended!

The failure is genuine and has identical root cause with https://github.com/jdb78/pytorch-forecasting/issues/1614