Closed fkiraly closed 2 months ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 80.48780%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 90.10%. Comparing base (
6061af6
) to head (20f606d
). Report is 1 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Isolates
matplotlib
as soft dependency in a new soft dep setall_extras
. https://github.com/jdb78/pytorch-forecasting/issues/1616The imports happen in
plot_sth
methods throughout the code base, some attached to classes, some not. This allows to usepytorch-forecasting
without plotting or graphical logging, or use a different plotting backend manually.Isolation strategy:
matplotlib
raises an exceptionmatplotlib
is additional or part of the logic, absence ofmatplotlib
causes the specific parts to be skipped. Example:log_gradient_flow
- this is crucial, as raising an exception would prevent the models from running.