search

sktime / pytorch-forecasting

Time series forecasting with PyTorch
https://pytorch-forecasting.readthedocs.io/
MIT License
3.99k stars 631 forks source link

[MNT] isolate `cpflows` to its soft dependency set #1637

Closed fkiraly closed 2 months ago

fkiraly commented 2 months ago

This Pr isolates cpflows to its soft dependency set again - I think it was already a soft dependency before we started to rework pyproject, somehow it ended up in dev?

This PR restores its original status as a soft dependency, as part of mqf2.

fkiraly commented 2 months ago

@benHeid, the change traces back to https://github.com/jdb78/pytorch-forecasting/pull/1628, but one of your (helpful) commits to it - any reason you also copied the dep into dev?

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.99%. Comparing base (27c3677) to head (5d5f97d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1637 +/- ## ======================================= Coverage 89.99% 89.99% ======================================= Files 32 32 Lines 4729 4729 ======================================= Hits 4256 4256 Misses 473 473 ``` | [Flag](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1637/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | Coverage Δ | | |---|---|---| | [cpu](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1637/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | `89.99% <ø> (ø)` | | | [pytest](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1637/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | `89.99% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benHeid commented 2 months ago

Oh this is a mistake. This shouldn't be in dev. It is required for some distributions I think...