sktime / pytorch-forecasting

Time series forecasting with PyTorch
https://pytorch-forecasting.readthedocs.io/
MIT License
3.99k stars 631 forks source link

[MNT] make `codecov` patch coverage informational #1639

Closed fkiraly closed 2 months ago

fkiraly commented 2 months ago

The codecov patch job, i.e., "how many lines of the diff are covered", can cause CI failures currently - these are misleading in particular if the code is maintenance or config code and itself not covered due to reasonable circumstances.

To avoid random failures in such cases, the patch coverage is turned to be informational. The total coverage condition, i.e., that total rpeository coverage should not drop too much through a PR, is not changed.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.20%. Comparing base (35766e2) to head (bd452cf). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1639 +/- ## ======================================= Coverage 90.20% 90.20% ======================================= Files 32 32 Lines 4729 4729 ======================================= Hits 4266 4266 Misses 463 463 ``` | [Flag](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | Coverage Δ | | |---|---|---| | [cpu](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | `90.20% <ø> (ø)` | | | [pytest](https://app.codecov.io/gh/jdb78/pytorch-forecasting/pull/1639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner) | `90.20% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Beitner#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.