Closed fkiraly closed 2 months ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 45.00000%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 90.14%. Comparing base (
95fa06c
) to head (38daba9
).
Files with missing lines | Patch % | Lines |
---|---|---|
pytorch_forecasting/models/base_model.py | 45.00% | 11 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Isolates
pytorch-optimizer
as soft dependency in a new soft dep setall_extras
. https://github.com/jdb78/pytorch-forecasting/issues/1616The imports happen only in
BaseModel
, when resolving aliases foroptimizer
.Isolation consists of two steps:
"ranger"
with"adam"
ifpytorch-optimizer
is not installed (left at"ranger"
if installed)Deprecation messages and actions are added, to changne the default to
"adam"
from 1.2.0, in order to minimize the number of dependencies in default parameter settings