Open fkiraly opened 1 week ago
Hello @fkiraly!
I'm interested in working on this issue and have started setting up ruff
to replace the existing linters. Could you please assign this issue to me?
Thank you!
Of course! You can look at @fnhirwa's work in sktime
in case you need a template.
Hello @fkiraly! I'm working on replacing the current linting tools with Ruff. However, I've encountered a situation I'd like to clarify:
I ran the pre-commit hooks using pre-commit run --all-files
with the current setup, and all checks passed without showing the "strange behaviors" mentioned in the issue description. I couldn't identify specific instances where the linter is "insisting on long single lines instead of line breaks."
Could you give me more specific examples of the issues you've had? This would help ensure that the new ruff
configuration addresses these problems effectively.
In the meantime, I'll go ahead and set up ruff
as the new linter. Once implemented, I'll test it thoroughly across the codebase and report back with the results.
Thanks!
I couldn't identify specific instances where the linter is "insisting on long single lines instead of line breaks."
That is because all lines are already compliant with the current linting - many files in the code base include lines well in excess of the 79 or even larger bounds on number of characters.
Further, if one tries to add line breaks, the linter resets them to "one line code".
We should move the linting to
ruff
- good first issue for a maintenance affine contributor.There are also some strange behaviours in the precommits which I cannot pinpoint, e.g., the linter insisting on long single lines instead of line breaks where they would be appropriate. Though I would hope this is resolved as a side effect of moving to
ruff
.