search

sktime / skbase

Base classes for creating scikit-learn-like parametric objects, and tools for working with them.
BSD 3-Clause "New" or "Revised" License
18 stars 11 forks source link

[BUG] `all_objects` returns variable name and not class name if these are different #112

Open fkiraly opened 1 year ago

fkiraly commented 1 year ago

From this refactor PR in sktime: https://github.com/sktime/sktime/pull/3777

It would appear that all_objects returns the variable name, not the class name, as the string (first tuple element) when the two are unequal.

I'm not entirely sure about the "should" here and whether that's indeed the root cause of the test failure, but it seems to be discrepant with behaviour in sktime.

RNKuhns commented 1 year ago

@fkiraly can you confirm this was fixed by #115.

fkiraly commented 1 year ago

It's not released yet, is it? Since 0.3.0 predates #115.

I've opened a version of the refactor branch with install from current skbase main branch, if the tests pass here, it should tell us whether it's fixed: https://github.com/sktime/sktime/pull/4208

RNKuhns commented 1 year ago

@fkiraly looks like sktime/sktime#4208 is failing, but not for the same reasons as the prior test. I think they might be un-related to BaseObject, but I haven't looked to closely (seems like errors had to do with missing parameters in construction in a few estimators and a test case).

fkiraly commented 1 year ago

yes, indeed. I'm not sure what causes these, seems like default parameter generation. I would put the functions that retrieve the set of parameters (like get_param_names) under suspicion.

This is the most recent change to this kind of function, in skbase, that I remember: https://github.com/sktime/skbase/issues/65