sktime / skpro

A unified framework for tabular probabilistic regression, time-to-event prediction, and probability distributions in python
https://skpro.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
246 stars 45 forks source link

[ENH] Consolidate quantile parameterized distributions in few classes #235

Closed fkiraly closed 3 months ago

fkiraly commented 7 months ago

@felixwick, @setoguchi-naoki, @Ram0nB I think we should consolidate the three curent quantile parameterized distribution (QPD) classes into a single one, and move the distribution logic in the quantile regressor in another QPD related class.

This idea is based on two observations:

I would suggest the following end state:

Do you have any thoughts about this suggestion? It might simplify the interface(s) of the connected regressors as well.

FelixWick commented 7 months ago

I think that makes sense. Also, instead of importing the J-QPD implementation from Cyclic Boosting, we might consider to create an independent class directly here in the new QPD module. (I know I suggested differently before, but your description changed my mind.)

fkiraly commented 7 months ago

Also, instead of importing the J-QPD implementation from Cyclic Boosting, we might consider to create an independent class directly here in the new QPD module. (I know I suggested differently before, but your description changed my mind.)

I think the "optimal state" is either that, or a lightweight interface, as for instance to scipy with Poisson.

fkiraly commented 3 months ago

Done in https://github.com/sktime/skpro/pull/232