Closed ShreeshaM07 closed 5 months ago
Makes sense - though, general question, is there a way we can avoid writing to the broadcast views?
I don't think that's possible as the logic for the broadcasting of these ragged arrays is that I replace these ragged arrays with an int
that represents the index which is then broadcasted based on the shape of index
and columns
parameters. I am then replacing these int
back with the ragged arrays. So I'm not sure if there's a way to avoid writing to broadcast views.
Reference Issues/PRs
fixes #412
What does this implement/fix? Explain your changes.
The error is due to the deprecation of the np.broadcast_arrays. https://numpy.org/doc/stable/reference/generated/numpy.broadcast_arrays.html So the bc is actually a tuple with broadcasted arrays whose values are getting reassigned.
PR checklist
For all contributions
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release. See here for full badge referenceFor new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensured dependency isolation, see the estimator dependencies guide.