Add Oscnn implementation

sktime / sktime-dl

DEPRECATED, now in sktime - companion package for deep learning based on TensorFlow

BSD 3-Clause "New" or "Revised" License

596 stars 79 forks source link

Add Oscnn implementation #111

Open tabhishek432 opened 3 years ago

tabhishek432 commented 3 years ago

Reference Issues/PRs

Fixes sktime/sktime#5828 #### What does this implement/fix? Explain your changes. It implements OSCNN #### Does your contribution introduce a new dependency? If yes, which one? Yes, it requires to install torch (pytorch) #### Any other comments? OSCNN is implemented in pytorch rather than tensorflow

tabhishek432 commented 3 years ago

Hi @TonyBagnall Sir, it would be very generous of you if you could please take a look at this code and approve it. Thanks!

TonyBagnall commented 3 years ago

hi, sorry for the delay. We will need to set up pytorch correctly, I think thats why its failing, I'll ask someone as I am not sure. Could you document the code? We are looking to improve the style of comments, and are looking to make it more like sktime. You can see here for the stryle we would like https://github.com/alan-turing-institute/sktime/blob/main/sktime/classification/dictionary_based/_boss.py

fkiraly commented 8 months ago

@tabhishek432, would you like to move this code to sktime? As state in https://github.com/sktime/sktime/issues/5828, pytorch backend is now compatible.