Don't refit onehot_encoder for validation data

sktime / sktime-dl

DEPRECATED, now in sktime - companion package for deep learning based on TensorFlow

BSD 3-Clause "New" or "Revised" License

596 stars 79 forks source link

Don't refit onehot_encoder for validation data #132

Closed cedricdonie closed 3 months ago

cedricdonie commented 2 years ago

Reference Issues/PRs

Fixes sktime/sktime#5864

What does this implement/fix? Explain your changes.

Currently, this leads to a bug when validation data has fewer classes than the training data since the onehot_encoder will be fit to the validation data categories.

Does your contribution introduce a new dependency? If yes, which one?

No new dependency

cedricdonie commented 3 months ago

Closed because sktime-dl has been moved to sktime, where the last remnants of this issue have been handled in https://github.com/sktime/sktime/pull/6373.