search

sktime / sktime-dl

DEPRECATED, now in sktime - companion package for deep learning based on TensorFlow
BSD 3-Clause "New" or "Revised" License
595 stars 79 forks source link

Mcdcnn regressor v2 #46

Closed Withington closed 4 years ago

Withington commented 4 years ago

Reference Issues/PRs

Added MCDCNN regressor for #18

Any other comments? Replaces PR #44 because the comparison seems incorrect. Included check_is_fitted as per #39 .

Withington commented 4 years ago

I reran the tests to check - this pull request is ok to merge. It is awaiting @James-Large review, what do you think James?

james-large commented 4 years ago

Yep this this is all good, doing each pr in turn, may as well leave this till last as it touches the least things

james-large commented 4 years ago

deeplearning/init conflicted from dev just on absolute vs relative paths, took dev.

To merge on successful checks