search

sktime / sktime-dl

DEPRECATED, now in sktime - companion package for deep learning based on TensorFlow
BSD 3-Clause "New" or "Revised" License
595 stars 79 forks source link

CI cron job for slow tests #54

Closed mloning closed 4 years ago

mloning commented 4 years ago

What does this implement/fix? Explain your changes.

Runs all tests on a daily basis if there have been changes to the source code on dev and master, including slow ones, to guarantee reproducibility of published results.

Reference Issues/PRs

As discussed in #51

mloning commented 4 years ago

@Withington the forecaster tests fail with nan values, any idea? Should we make them into flaky tests?

Withington commented 4 years ago

How often is it failing with NaN, just this one time? They’ve been fine up until now so has something changed?

mloning commented 4 years ago

I'm also not sure why this comes up now, haven't changed any source code, only the azure yaml files ... restarted the tests.

mloning commented 4 years ago

Now they pass, looks like a flaky case to me :-)

mloning commented 4 years ago

This is good to go from my side. Let me know what you think @Withington @James-Large

mloning commented 4 years ago

I'm actually not sure, we'll have to see, but if we want it to run for all PRs I could add it to the ci.yml, that may be easier, from the checks that run on this PR, it doesn't look like it