search

sktime / sktime-dl

DEPRECATED, now in sktime - companion package for deep learning based on TensorFlow
BSD 3-Clause "New" or "Revised" License
595 stars 79 forks source link

Bug fix #74 Problem with sktime-dl installation #85

Closed oustella closed 3 years ago

oustella commented 3 years ago

Reference Issues/PRs

Fixes #74 (partially) The installation problem seems to be related to not able to locate check_X_y from the sktime v0.4.x. I located where the method should be in sktime and updated the import line for the _cnn.py module. If this pull request is accepted, I will update the same line for the other classifiers. This is the first time I'm contributing, I wanted to make sure I did it correctly. Please let me know.

mloning commented 3 years ago

@oustella yes this look good. There seem to be a merge conflict. Can you take a look?

oustella commented 3 years ago

@mloning I could be wrong - it seems that pull requests cannot be made to a specific tag because a tag is a commit that cannot be moved [reference: this post]. In fact, the conflict warning goes away if I compare my branch with v0.1.0 as the base from sktime/sktime-dl, but then the pull request button disappears too. Hmm.. please feel free to close this PR if you think that's the case and let me know if there is any other ways I can contribute to the past version, or the current version under development. I'm a phd student working on time series data and find the sktime resources valuable.

mloning commented 3 years ago

Hi @oustella, I suggest we work towards a new version! Even if we fix the current version, we could update the release on PyPI. Let's try to bring sktime-dl back up to speed with the latest sktime release and then push a new release.

oustella commented 3 years ago

@mloning sounds great!

mloning commented 3 years ago

@oustella if you have the time, it'd be great to open a PR based on the current master.