search

sktime / sktime-neuro

time series machine learning for neurological data
9 stars 3 forks source link

merge this into sktime? #22

Open fkiraly opened 2 years ago

fkiraly commented 2 years ago

I was just looking at this repo, and I think this has a number of transformers which are simply generally useful!

Why don´t we just merge them into sktime?

I do not see a downside of doing that.

In addition, the base class here has gone out of sync with sktime... This can be easily refactored however.

Let me know if you are still actively working on this, @SveaMeyer13 - either way, I can help move.

fkiraly commented 2 years ago

Shouldn´t be too difficult - see here: https://github.com/alan-turing-institute/sktime/pull/3067

SveaMeyer13 commented 1 year ago

I like the idea - but I won't have time to take care of it!