search

sktime / sktime

A unified framework for machine learning with time series
https://www.sktime.net
BSD 3-Clause "New" or "Revised" License
7.58k stars 1.29k forks source link

[BUG] `prophet` based forecasters incompatible with `numpy 2.X` #6720

Open fkiraly opened 4 days ago

fkiraly commented 4 days ago

It seems that prophet based forecasters are incompatible with numpy 2.X, because prophet itself contains type hints using np.float_ which is deprecated.

This is a bug in prophet, as its package bounds do not indicate < numpy 2.X. For now, we can avoid this failure in our tests and on user side by bounding the dependencies in the two affected forecasters:

This is temporary and should be tracked until resolved on the side of prophet.

Once resolved, the bound can be removed by reverting https://github.com/sktime/sktime/pull/6721.

yarnabrina commented 4 days ago

I am curious how you caught this issue. Type hints in prophet should not be caught in any testing in sktime won't be able to detect that, right?

Is there any way to identify such limitations for dependencies? I'd like to use the same in office work too.

fkiraly commented 3 days ago

I am curious how you caught this issue.

I think I just did a test-all, prophet itself does not imply numpy<2, so it runs on the numpy 2 env and trips the failure.