Editing document type hides tabs as if they're overflowing

skttl / umbraco-matryoshka

Matryoshka enables you to layer your document type properties in tabs and groups

MIT License

13 stars 10 forks source link

Editing document type hides tabs as if they're overflowing #15

Closed stefankip closed 4 years ago

stefankip commented 4 years ago

Steps to reproduce:

Open a content item
Open the document type via the Info app
Save and close the document type
Open the Content app again Now the tabs are hidden as if they're overflowing.

FransdeJong commented 4 years ago

If you resize the screen by only one pixel it resolves itself. So maybe we could call the calculateWidth() function every time you open the Content tab this would be fixed right?

skttl commented 4 years ago

It does the same whenever you open an infinite editor, ie. when editing DTGEs.

FransdeJong commented 4 years ago

I don't experience the same behaviour with DTGE or another infinite editor. Even if I go to edit the doctype and hit close instead of submit it doesn't behave like this.

It only callapses when I edit the doctype and hit submit

skttl commented 4 years ago

https://github.com/skttl/our-umbraco-matryoshka/commit/a5d61d425380e12c8419616b3df2162fa4d8c66cchanges the logic from using window resize events to using a ResizeObserver. ResizeObserver is currently behind a flag in Safari (I guess Safari 14 which should be due anytime soon will have it), else its supported in all modern browsers.

stefankip commented 4 years ago

Correct link: https://github.com/skttl/our-umbraco-matryoshka/commit/a5d61d425380e12c8419616b3df2162fa4d8c66c