skttl / umbraco-matryoshka

Matryoshka enables you to layer your document type properties in tabs and groups
MIT License
13 stars 10 forks source link

Validation on mandatory properties not working and icon-alert constantly showing #16

Closed prgriffithsdev closed 4 years ago

prgriffithsdev commented 4 years ago

Hi,

I have just run the following Install-Package Our.Umbraco.Matryoshka -Version 0.2.0 and the validation on mandatory properties is not working.

13

Also, on the tabs, the validation the alert icon () always diplays as if validation has already triggered ?

12

I think validation of mandatory properties was and issue but the icon issue wasn't a problem in the previous versions so it was something that was changed recently. I think its related to the validation css in

App_Plugins\Our.Umbraco.Matryoshka\tabbed-content.css

Im unsure if this is getting picked up?

.matryoshka-tabs-list .umb-tab i.icon {
    display: none;
}

thanks Paul

skttl commented 4 years ago

Just tried a clean Umbraco 8.6 and Matryoshka 0.2, but can't reproduce. Can you provide steps to reproduce?

prgriffithsdev commented 4 years ago

Hey @skttl,

Is there anything else I can try?

Thank you for looking

Paul

skttl commented 4 years ago

Thanks for getting back :)

Try bumping the version number in config/clientdependency.config, and then a hard reload in your browser (in Chrome, open dev tools, right click the reload button, select hard reload)

prgriffithsdev commented 4 years ago

Hi @skttl,

I feel so bad right now! Hard reload solves the issue!! FML. I was working on this late last night and it was obviously time to call it a day! You have to love chrome.

Apologies for raising this issue but thank you for being supportive and responding quickly.

This package is great, thank you for developing and sharing it!

Paul

skttl commented 4 years ago

No worries - been there done that 😂

skttl commented 4 years ago

HI @prgriffithsdev

I know what your problem was. Your browser caches the view for the directive (/App_Plugins/Our.Umbraco.Matryoshka/directives/matryoshka-tabbed-content.html). This part is not handled by client dependency, but I think you can get the current version and append that as a query string parameter, to bust the browser cache.

I'll reopen, so I can get it fixed :)

prgriffithsdev commented 4 years ago

Hi @skttl ,

Thanks for letting me know i wasn't going crazy :).

Ill keep an eye for the fix and pull it in when you get around to solving it :). All is working fine since it resolved the other day

Thank you

skttl commented 4 years ago

Fixed in 8e339da