search

skttl / umbraco-matryoshka

Matryoshka enables you to layer your document type properties in tabs and groups
MIT License
13 stars 10 forks source link

Group Separator Expand / Collapse functionality is broken in 8.7 #32

Closed mjbarlow closed 3 years ago

mjbarlow commented 4 years ago

In v8.7 the expand and collapse functionality doesn't work for the group separator.

I installed a clean version of 8.7 with the latest matryoshka and added a group separator, as you can see the property editors aren't captured inside of the expand / collapse functionality.

matryoshka_error

chris-evansnz commented 4 years ago

I'm also encountering this issue, umbraco version 8.7.0 and Our.Umbraco.Matryoshka version 0.5.0

There isn't much documentation around how the Matryoshka Group Separator is supposed to be used or configured, but I assume you're just meant to add one in front of the properties you want to include in the group?

mjbarlow commented 4 years ago

@chris-evansnz you are correct, you just add the separator as a property to a group and it takes care of the rest.

FransdeJong commented 4 years ago

I fixed this in https://github.com/skttl/umbraco-matryoshka/pull/33

The issue is that since 8.7 Umbraco introduced a umb-property directive. This wraps the div with the class umb-property where the matryoshka classes were added to.

To maintain backwards compatibility I check if the div with class umbr-directive has a parent element umb-directive. If so I assign it to separator so all logic on the our-matryoshka-group-separator-container class works as intended.

Also I had to do some small css changes to fix the way the separators are displayed.

I tested this PR against v8.8 and v8.6.4