skttl / umbraco-matryoshka

Matryoshka enables you to layer your document type properties in tabs and groups
MIT License
13 stars 10 forks source link

Umbraco 9 compatibility #56

Closed chris-evansnz closed 3 years ago

chris-evansnz commented 3 years ago

Just wondering if anyone has successfully used matryoshka in the Umbraco 9 beta-001 release?

I seemed to get it working by copying the App_Plugins files into wwwroot but it mysteriously stopped working a day later. Installing via the nuget package didn't work either (wishful thinking but worth a try)

Is there a plan for a v9 version; and is there any best-practice way to get App_Plugins based directives etc to work in asp.net core / v9?

skttl commented 3 years ago

When it stopped a day later, did the files still exist in the App_Plugins folder? Sounds more like a bug in Umbraco, or your setup if the files dissapeared.

There is currently no plans for v9, as I expect cores own tabs functionality to be ready soon. And Matryoshka already works in v9 as it's only js/html/css which is compatible with both v8 / v9.

chris-evansnz commented 3 years ago

No, the files were still there, it just doesn't show the tabs. Not sure why?

bielu commented 3 years ago

@skttl based on that https://github.com/umbraco/Umbraco-CMS/issues/9442, I somehow dont believe tabs will actually return to core as that is already 8 months without update of ticket about tabs, so lets be honest it might not happen. :)

skttl commented 3 years ago

@bielu it is happening https://github.com/umbraco/Umbraco-CMS/tree/v8/prototype%2Fdoctype-tabs

skttl commented 3 years ago

Regarding this issue, I'm pretty sure it's a bug in the beta. If the files is there, theres nothing I can do...

markadrake commented 3 years ago

After running dotnet add package Our.Umbraco.Matryoshka I can confirm that the appropriate files are not added to my project.

image

So I downloaded the latest release (0.7.0), unzipped the files, and placed them correctly under App_Plugins.

image

I can confirm that the tabs are in place and in working order.

image

skttl commented 3 years ago

Yes, I guess I need to create a nuget package with build targets for copying the files into the site for v9.

I'll see if I can find out if HQ are getting their tabs implementation done before v9, before I do it though.

skttl commented 3 years ago

With the current plans for adding tabs back into the backoffice, the roadmap for Matryoshka is now: