search

skubalj / build_html

Library for basic server-side rendering written in pure rust https://crates.io/crates/build_html
MIT License
29 stars 5 forks source link

Add table footer methods #16

Closed nricciardi closed 3 months ago

nricciardi commented 3 months ago

Table does not have footer methods such as add_tfoot_attributes, add_footer_row or add_custom_footer_row.

nricciardi commented 3 months ago

I created a pull request where I added those methods. Thanks

skubalj commented 3 months ago

Thanks so much for opening up a PR! It looks like we have a couple failing tests, which I will address. I've merged your PR into a staging branch while I work on that, and I'll update this ticket when I've merged to main.

Regarding getting this published to crates.io: I've needed to update some documentation and get a new version out for a while now. I will make a point to put some time into this over the next week.

skubalj commented 3 months ago

Just a heads-up: this is merged to main. I have made a change so that the footer only appears when it has children or attributes set. That way, existing users who update to the next version will not see changes in their output.

nricciardi commented 3 months ago

Oh sorry. Honestly I did not think about it. Next time I'm going to watch code more in depth.

I was happy to contribute to this project, even because I'm using it in my other project (pure Rust Markdown compiler) and I need the table footer.

I await the new version with interest. Thank you.