search

skuethe / MMM-Spotify

Spotify display and controller for MagicMirror
MIT License
68 stars 17 forks source link

fill accountList only when available #160

Closed lavolp3 closed 3 years ago

lavolp3 commented 3 years ago

Otherwise DOM will create an error because there was no AccountList DOM entry. This is only created when the user activates the accountList in config.

skuethe commented 3 years ago

Thank you for the PR @lavolp3 . Two things I came across:

  1. You added package-lock.json to gitignore, but added it in your first commit - so please remove that file again
  2. Can you please also adjust the updateDeviceList function - it's the same buildup, so just move the payload block into the deviceList if clause (row ~ 401)
lavolp3 commented 3 years ago

Thank you for the PR @lavolp3 . Two things I came across:

  1. You added package-lock.json to gitignore, but added it in your first commit - so please remove that file again
  2. Can you please also adjust the updateDeviceList function - it's the same buildup, so just move the payload block into the deviceList if clause (row ~ 401)

Both done ✅