skufog / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

rotate test under unit_test do not consider iteration #233

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It was noticed that the rotate tests under unit_test just run 1 time without 
leveraging the iteration settings as the other test cases do. Would it be 
better for performance comparison by introducing the iteration settings?
Referential Patch attached. 

Original issue reported on code.google.com by changjun...@intel.com on 23 May 2013 at 10:48

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the submission.  I'll run some tests to make sure its the right 
behavior and get back to you.

I know the rotation tests are somewhat flawed in their support for odd 
width/height and/or width of 1, and could use a bit of work.

Also the actual ARGB rotate, albiet assembly, is not efficient.  It should be 
reimplemented the same as YUV.

Original comment by fbarch...@google.com on 24 May 2013 at 11:27

GoogleCodeExporter commented 9 years ago
Patch updated.

Original comment by changjun...@intel.com on 28 May 2013 at 3:06

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in r701.
Its not a very good unittest though... keeping open for cleanup.

Original comment by fbarch...@google.com on 28 May 2013 at 7:51

GoogleCodeExporter commented 9 years ago
Rewrite tests in r705.

Original comment by fbarch...@google.com on 28 May 2013 at 10:44