search

skuill / LyricsScraperNET

🎼 LyricsScraperNET is a .NET library to search for lyrics of a song from the web.
MIT License
5 stars 1 forks source link

Error when searching for lyrics of an instrumental track #17

Closed skuill closed 10 months ago

skuill commented 11 months ago

Artist: HIM, Song: Lucifer's Chorale image

skuill commented 11 months ago

Genius provider throw this error while trying to parse the html page with a lyric. SearchLyric method should not throw any exceptions and break users code. Only log errors. TODO: 1) Try Catch providers exceptions and log them. 2) Properly parse instrumental lyrics in providers. 3) Mark empty lyric response in case of instrumental lyric. 4) Add ability to configure logger in client/providers from ILoggerFactory. 5) Add Unit Tests (integration?) in case of instrumental lyric.

skuill commented 11 months ago

1) https://www.musixmatch.com/lyrics/409/49881086 image 2) AZLyrics did not find any instrumental song 3) https://genius.com/Rush-yyz-lyrics image 4) https://www.songlyrics.com/rush/yyz-lyrics/ image 5) https://lyrics.lyricfind.com/lyrics/rush-yyz image

skuill commented 10 months ago

Released in https://github.com/skuill/LyricsScraperNET/releases/tag/1.6.1