skulegirl / django-allauth-sniperlinks

Django app to generate Sniper Links for unverified allauth email addresses, allowing users to find verification emails quickly.
MIT License
7 stars 1 forks source link

Improvements #2

Open blag opened 10 months ago

blag commented 10 months ago

Python's method resolution order makes it difficult to use the SniperLinkAccountAdapter with another adapter.

Instead, I split it out into a SniperLinkAccountAdapterMixin that only defines the add_message method, and refactored SniperLinkAccountAdapter for backwards compatibility.

I also used a real project in the example when I updated the README.

And then while I was updating the documentation, I made a few more tweaks to the Markdown.

Thank you for this project, sniper links are cool! If you can publish a new release once these changes are merged, I'd appreciate it.

blag commented 8 months ago

@skulegirl Do you have any feedback on this?