search

skullernet / q2pro

Enhanced Quake 2 client and server
GNU General Public License v2.0
243 stars 82 forks source link

Patch: Implement SV_ConsoleOutput #81

Open hifi opened 10 years ago

hifi commented 10 years ago

We've been needing remote logging for statistics for quite some while. Today, I wrote a very minimal implementation of SV_ConsoleOutput to fill that gap.

Cvar is named after the Source engine one. Though, worth noting is that the Source engine also supports multiple log servers by using logaddress_add.

I used the Q2 style echo header which should be "rcon compatible".

http://hifi.iki.fi/0001-Implement-SV_ConsoleOutput.patch

skullernet commented 1 year ago

I don't see much value in implementing remote logging over unreliable transport. Rather than losing data it's better to have no remote logging at all, forcing the user to keep logs locally.

Even reliability issues aside, proposed implementation is way too minimal. Sending an UDP packet on each Com_Printf() call is not acceptable. There needs to be some kind of line buffering, preferably merging of several lines printed in quick succession into single packet.