search

skullone / android_firewall

This is a fork of Droidwall by Rodrigo Zechin Rosauro - http://code.google.com/p/droidwall/
128 stars 91 forks source link

cannot change language to Portuguese and Chinese in settings menu #24

Closed iptux closed 11 years ago

iptux commented 11 years ago

is it possiable to add a option to follow system language settings?

skullone commented 11 years ago

I can add the ability to set it back to the system language.

As for the Portuguese and Chinese languages. I'm still working on those. The issue is with their locale code. zh-rCN for the Simplified Chinese for example. Using zh-rCN in the code doesn't make the app change to the Simplified Chinese translation. If I put the translation in values-zh I can make it work but then I have Simplified Chinese translation where a Traditional Chinese translation should exist. I want to make sure I do it right. Hopefully I can get it figured out for 2.1.9.

skullone commented 11 years ago

Does the app now default to English which is making the lack of Portuguese and Simplified Chinese more of a problem?

On Sun, Apr 7, 2013 at 4:24 AM, Tommy Alex notifications@github.com wrote:

is it possiable to add a option to follow system language settings?

— Reply to this email directly or view it on GitHubhttps://github.com/skullone/android_firewall/issues/24#issuecomment-16011420 .

iptux commented 11 years ago

yes, English is the default

skullone commented 11 years ago

My bad. I'll push a fix tomorrow. On Apr 8, 2013 8:04 PM, "Tommy Alex" notifications@github.com wrote:

yes, English is the default

— Reply to this email directly or view it on GitHubhttps://github.com/skullone/android_firewall/issues/24#issuecomment-16086754 .

skullone commented 11 years ago

I have pushed the fix to Github. I will post the app to the Play Store later today after I get some testing done on it first as I fixed a NullPointerException as well in 2.1.9. My sincere apologies for the mix up. After you confirm things are working correctly for you again I will close the issue.

iptux commented 11 years ago

will be fixed in issue #26